Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI pipeline to the project #3

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

ctw-joao-luis
Copy link

@ctw-joao-luis ctw-joao-luis commented Oct 10, 2024

Created and implemented a CI pipeline based on other projects associated with Lichtblick, it was tested on a fork before and ran successfully.

Removed build from the test script on package.json because, since the pipeline already calls yarn build before calling yarn test, including build inside test was redundant and unnecessary.

@laisspportugal
Copy link

I just have one question, besides that looks good to me

Copy link

@laisspportugal laisspportugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ctw-joao-luis ctw-joao-luis merged commit 0221b50 into main Oct 10, 2024
1 check passed
@ctw-joao-luis ctw-joao-luis deleted the feature/implementing-ci-cd-pipeline branch October 10, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants